Skip to content

Conversation

@joaomoreno
Copy link
Member

@joaomoreno joaomoreno commented Apr 21, 2020

This aims to implement the RemoteSourceProvider interface for adding the ability to clone GitHub repositories without copy pasting their URLs.

Fixes #1547

@joaomoreno joaomoreno added this to the April 2020 milestone Apr 21, 2020
@joaomoreno joaomoreno self-assigned this Apr 21, 2020
src/extension.ts Outdated
registerCommands(context, prManager, reviewManager, telemetry);

const gitExtension = vscode.extensions.getExtension<GitExtension>('vscode.git')!.exports;
const gitAPI = gitExtension.getAPI(1);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexr00 I've extracted getting the GitAPI here, so it can be reused in initializing GithubRemoteSourceProvider.

Copy link
Member Author

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_

@joaomoreno joaomoreno marked this pull request as draft April 21, 2020 13:31
@joaomoreno joaomoreno marked this pull request as ready for review April 21, 2020 13:58
@joaomoreno
Copy link
Member Author

I believe this is good to go. Complete functionality from the Git extension should land tomorrow on Insiders.

Copy link
Contributor

@RMacfarlane RMacfarlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@joaomoreno joaomoreno merged commit a1d82e4 into master Apr 22, 2020
@joaomoreno joaomoreno deleted the joao/git-remote-provider branch April 22, 2020 10:56
@dbaeumer dbaeumer mentioned this pull request Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Contribute a GH repository picker to the Git: Clone command

3 participants