Enable issue details editing #1659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RMacfarlane
approved these changes
Apr 22, 2020
| return; | ||
| } | ||
| const title = text.substring(0, indexOfEmptyLine); | ||
| const body = text.substring(indexOfEmptyLine + 2); |
Contributor
There was a problem hiding this comment.
should we trim off the explanation comment from the issue body?
Member
Author
There was a problem hiding this comment.
I would leave it, similar to how GitHub leaves the comment in the issue templates.
src/issues/issueFeatureRegistrar.ts
Outdated
| return; | ||
| } | ||
| text = vscode.window.activeTextEditor.document.getText(); | ||
| const indexOfEmptyLine = text.indexOf('\n\n'); |
Contributor
There was a problem hiding this comment.
is it at all possible that the line ending would be changed on save or anything like that?
Member
Author
There was a problem hiding this comment.
Yes, added some handling for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1608