Skip to content

Inline issue action to go to query#1633

Merged
alexr00 merged 1 commit intomasterfrom
alexr00/issue1622
Apr 16, 2020
Merged

Inline issue action to go to query#1633
alexr00 merged 1 commit intomasterfrom
alexr00/issue1622

Conversation

@alexr00
Copy link
Member

@alexr00 alexr00 commented Apr 15, 2020

Fixes #1622

@alexr00 alexr00 requested a review from RMacfarlane April 15, 2020 14:49
await vscode.commands.executeCommand(command);
const editor = vscode.window.activeTextEditor;
if (editor) {
const text = editor.document.getText();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool! The "Configure Queries" action for changing the pull request queries just opens the settings page with prefilled search text, this seems much better. I'll create an issue to match this behavior with that action

@alexr00
Copy link
Member Author

alexr00 commented Apr 16, 2020

This is really cool! The "Configure Queries" action for changing the pull request queries just opens the settings page with prefilled search text, this seems much better. I'll create an issue to match this behavior with that action

In very large settings files it will likely be slow, but since it's not an action I expect people to take very often it seemed worth it!

@alexr00 alexr00 merged commit 572cbd4 into master Apr 16, 2020
@alexr00 alexr00 deleted the alexr00/issue1622 branch April 16, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support to navigate from an issue query to its definition in the settings.

2 participants