Improve visibility of PR controls to take into account user write permission#1433
Merged
RMacfarlane merged 2 commits intomicrosoft:masterfrom Nov 1, 2019
Merged
Conversation
RMacfarlane
approved these changes
Nov 1, 2019
Contributor
RMacfarlane
left a comment
There was a problem hiding this comment.
Thank you @IllusionMH! Looks good!
Contributor
Author
|
Thanks for quick review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1408
Added checks if current user has write permission to repo to elements that are only available to collaborators.
Fixes #1065
Extended definition/calculation of
canEditto specify that PR author and collaborator(current user) has edit access to PR description/title.Edit access on separate comments is already controlled by
viewerCanEditflag on each comment.Editing review summary comment is not implemented at this moment and out of scope of this PR.