Don't prompt for sign in after user has ignored once. #1406
Merged
RMacfarlane merged 4 commits intomasterfrom Oct 24, 2019
Merged
Don't prompt for sign in after user has ignored once. #1406RMacfarlane merged 4 commits intomasterfrom
RMacfarlane merged 4 commits intomasterfrom
Conversation
RMacfarlane
suggested changes
Oct 24, 2019
Contributor
RMacfarlane
left a comment
There was a problem hiding this comment.
Looks good, only have minor comments
| @@ -0,0 +1,25 @@ | |||
| import * as vscode from 'vscode'; | |||
|
|
|||
| export type GlobalStateContext = { globalState: vscode.Memento }; | |||
RMacfarlane
approved these changes
Oct 24, 2019
Member
|
@JacksonKearl since this line |
Contributor
Author
|
@rebornix Oops, yeah I had that in for testing. Fixed on master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1389.
Added a new persistent global state store, as it seems like the existing solution (authentication/keychain.ts) was pretty heavily tied to passwords/keytar.