Support images in 'review' and pr diff viewers#1387
Merged
RMacfarlane merged 7 commits intomasterfrom Oct 18, 2019
Merged
Conversation
58ecdc4 to
17e01f6
Compare
17e01f6 to
b2f21fd
Compare
RMacfarlane
suggested changes
Oct 17, 2019
Contributor
RMacfarlane
left a comment
There was a problem hiding this comment.
Nice work! Just a few minor comments
pr diff viewers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1356.
Uses a trick from the builtin git extension to represent images as data URL's, as the
provideTextDocumentAPI does not handle images. There is afileSystemProviderAPI that we could use instead, but it ends up being more complicated.