Fetch branch prior to checking if its behind remote#1371
Merged
RMacfarlane merged 3 commits intomasterfrom Oct 10, 2019
Merged
Conversation
Contributor
Author
|
@RMacfarlane do you know what this "Failed to get the latest version of package RichCodeNav.ClientTool." issue is? |
Contributor
|
@JacksonKearl We have an extra build step that tries to index the current state of the repo to allow language features like go-to-definition to work for files that aren't on disk, but it's sometimes flakey. I'm considering just removing it. It can safely be ignored |
RMacfarlane
approved these changes
Oct 10, 2019
Contributor
RMacfarlane
left a comment
There was a problem hiding this comment.
Change looks good to me! Sorry for pushing erroneous commits here :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we called
getBranchwithout having priorfetch'd for any new commits, causing us to read stale data.Fixes #1368.