Skip to content

Set a default array for githubPullRequests.remotes#1291

Merged
RMacfarlane merged 1 commit intomasterfrom
rmacfarlane/remote-setting
Aug 9, 2019
Merged

Set a default array for githubPullRequests.remotes#1291
RMacfarlane merged 1 commit intomasterfrom
rmacfarlane/remote-setting

Conversation

@RMacfarlane
Copy link
Contributor

@RMacfarlane RMacfarlane commented Aug 5, 2019

Fixes #1289

Simplifies logic for reading remotes to only reading that setting, if no matches are found we already display text about this with a command for configuring the setting

@RMacfarlane RMacfarlane requested a review from rebornix August 5, 2019 16:38
@RMacfarlane RMacfarlane merged commit b20ea6f into master Aug 9, 2019
@RMacfarlane RMacfarlane deleted the rmacfarlane/remote-setting branch September 6, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

githubPullRequests.remotes default should be ["origin", "upstream"] and disallow null

1 participant