Skip to content

Fix updates to outdated comments#1280

Merged
RMacfarlane merged 1 commit intomasterfrom
rmacfarlane/outdatedComments
Jul 22, 2019
Merged

Fix updates to outdated comments#1280
RMacfarlane merged 1 commit intomasterfrom
rmacfarlane/outdatedComments

Conversation

@RMacfarlane
Copy link
Contributor

@RMacfarlane RMacfarlane commented Jul 22, 2019

Fixes #1279

The same update function was being called for updating outdated comments and file comments, but it was always reading from file comment data.

@RMacfarlane RMacfarlane requested a review from rebornix July 22, 2019 17:39
@RMacfarlane RMacfarlane self-assigned this Jul 22, 2019
Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RMacfarlane RMacfarlane merged commit 0bc1814 into master Jul 22, 2019
@RMacfarlane RMacfarlane deleted the rmacfarlane/outdatedComments branch July 22, 2019 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comments get disposed from file that has both recent and outdated comments

2 participants