Skip to content

Do not show commands before extension has fully activated#1212

Merged
RMacfarlane merged 1 commit intomasterfrom
rmacfarlane/commandClauses
Jun 6, 2019
Merged

Do not show commands before extension has fully activated#1212
RMacfarlane merged 1 commit intomasterfrom
rmacfarlane/commandClauses

Conversation

@RMacfarlane
Copy link
Contributor

@RMacfarlane RMacfarlane commented Jun 5, 2019

Fixes #1198

See the "activate" function in extension.ts, we need a git repository to be present to finish extension set up. The git extension has a "gitOpenRepositoryCount" context key we can check so that commands are not shown before they are registered

Copy link
Contributor

@kuychaco kuychaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🚢

@RMacfarlane RMacfarlane merged commit 02ecb59 into master Jun 6, 2019
@RMacfarlane RMacfarlane deleted the rmacfarlane/commandClauses branch June 6, 2019 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

all github commands cannot be found.

2 participants