Make sure author association is set on review events#1207
Merged
RMacfarlane merged 1 commit intomasterfrom Jun 6, 2019
Merged
Conversation
kuychaco
approved these changes
Jun 6, 2019
|
|
||
| export function parseGraphQLTimelineEvents(events: (GraphQL.MergedEvent | GraphQL.Review | GraphQL.IssueComment | GraphQL.Commit | GraphQL.AssignedEvent)[], githubRepository: GitHubRepository): Common.TimelineEvent[] { | ||
| let ret: Common.TimelineEvent[] = []; | ||
| const normalizedEvents: Common.TimelineEvent[] = []; |
Contributor
There was a problem hiding this comment.
💯 for descriptive variable names
| let commitEv = event as GraphQL.Commit; | ||
| ret.push({ | ||
| normalizedEvents.push({ | ||
| id: commitEv.databaseId, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1175
We do authorAssocation.toLowerCase() in the WebView, but were not correctly setting authorAssocation on review events when using the REST API. There's still an "any" that's destroying type safety in the function converting the REST response to normalized form, we need to update our octokit typings. I removed some casts in our GraphQL conversion function that were preventing type checking.