Decrease time to enter review mode.#1131
Merged
queerviolet merged 1 commit intomasterfrom May 2, 2019
Merged
Conversation
Previously, we awaited the fetch of additional PR data, then checked out the branch. Now, we attempt to checkout the branch, and then we fetch additional data. We also add more specific status bar messages, and immediately update the status bar message once the branch is checked out, indicating to the user that they can go about their day while we fetch additional information. Tested manually, on fast / slow / nonexistent connections, with branches that both do and do not exist locally (the latter fail, as we would expect).
rebornix
approved these changes
Apr 30, 2019
| this.switchingToReviewMode = false; | ||
| await this._repository.status(); | ||
| try { | ||
| this.statusBarItem.text = `$(sync~spin) Fetching additional data: pr/${pr.prNumber}`; |
Member
There was a problem hiding this comment.
This one can be skipped if the pull request has all information needed?
Contributor
Author
There was a problem hiding this comment.
It didn't seem obvious and quick to see if it has all the information needed. Maybe we can do another easy-win PR to early-out in fullfillPullRequestMissingInfo if it's all there?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Low-hanging fruit for #1091.
Previously, we awaited the fetch of additional PR data, then checked out
the branch. Now, we attempt to checkout the branch, and then we fetch
additional data.
Also:
the user that they can go about their day while we fetch additional
information
Tested manually, on fast / slow / nonexistent connections, with branches
that both do and do not exist locally (the latter fail, as we would
expect).