Pull Request Tree GitHub Enterprise Avatars #1121
Merged
StanleyGoldman merged 4 commits intomasterfrom May 1, 2019
Merged
Conversation
Contributor
Author
|
|
2 tasks
queerviolet
approved these changes
Apr 19, 2019
Contributor
queerviolet
left a comment
There was a problem hiding this comment.
Gonna merge this in. Thanks for DI'ing it into this branch!
Contributor
|
Oops, wrong PR |
queerviolet
approved these changes
Apr 22, 2019
RMacfarlane
approved these changes
Apr 29, 2019
…b-enterprise-user-avatar # Conflicts: # src/github/githubRepository.ts
48ca2da to
3abb635
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #416
This pull request corrects the display of GitHub Enterprise Avatars in the Pull Request Tree
.svgfor "dark GitHub"GitHubRepositoryto test if an avatar url returns with an HTTP 200 or otherPullRequestModelto return undefined if the server does not return avatarsPullRequestNodeto display a substitute local resource if an avatar is undefined