Create Pull Request Suggestions silently fails when the suggestion is on the first line #6603
Description
- Extension version: 0.102.0
- VSCode Version: 1.96.2
- OS: Linux x64 5.14.0-503.19.1.el9_5.x86_64
- Repository Clone Configuration (single repository/fork of an upstream repository): fork of an upstream repository
- Github Product (Github.com/Github Enterprise version x.x.x): Github.com
Steps to Reproduce:
I've seen this a few times and I'm not sure how to reliably reproduce it. Possibly it happens when making a suggestion on a file that has a single line (e.g. a changelog fragment file), or a file that was newly created in the PR.
- Locally check out a PR with the extension.
- Rewrite a line in the editor.
- Click "Create Pull Request Suggestions" in the source control panel, or right click the file and click "Create Pull Request Suggestions"
The dialog saying "All changes have been converted to suggestions" appears. If you click "Reset all changes", nothing happens. The changes were not converted to suggestions. Refreshing GitHub shows nothing. No new messages show in the extension logs (at least nothing at info level or above).