Skip to content

Email address for merge commit is not remembered (and cannot be set) #6593

@frossie

Description

@frossie

Following from #5326 which added the ability to choose the e-mail address associated with a merge commit (thank you!)

Problem: if you want a different value (for the e-mail to be associated with your merge commit,) than the one the extension defaults to, you have to change it every time.

  • Ideally, the e-mail selected would default to the one configured in the local git repository

As is, if you have made commits from eg. your work computer and you forget to switch out the email associated with the merge commit (that seems to default to the on your personal Github profile) you end up with the merge commit being with a different e-mail than the rest of your commits. The best option is for the extension to default to the email that matches the git config user.email (provided it matches one of the email addresses returned by the Github API of course)

  • Alternatively, the extension could default to the last value chosen in the extension

This is the behavior of the Github UI and probably deals with the vast majority of annoyances.

  • Or, it could be settable as an extension property

This is less than ideal because of people who do open source and employer commits under separate e-mails from the same environment, but it would be an improvement on the current situation.

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions