Skip to content

Extension asks for commenting ranges on a file that got deleted in PR #6046

@bpasero

Description

@bpasero

In microsoft/vscode#214588, a file workbench.desktop.nls.js is deleted, yet I see many errors printed for the extension asking to resolve comment ranges:

ExtHostDocuments.ensureDocumentData (/Users/bpasero/Development/Microsoft/vscode-electron-22.x/src/vs/workbench/api/common/extHostDocuments.ts:88)
<anonymous> (/Users/bpasero/Development/Microsoft/vscode-electron-22.x/src/vs/workbench/api/common/extHost.api.impl.ts:1047)
process.processTicksAndRejections (internal/process/task_queues:95)
Promise.then (Unknown Source:0)
openTextDocument (/Users/bpasero/Development/Microsoft/vscode-electron-22.x/src/vs/workbench/api/common/extHost.api.impl.ts:1043)
updateResourcesWithCommentingRanges (/Users/bpasero/.vscode-oss-dev/extensions/github.vscode-pull-request-github-0.89.2024053108/dist/extension.js:2044)
Vr (/Users/bpasero/.vscode-oss-dev/extensions/github.vscode-pull-request-github-0.89.2024053108/dist/extension.js:2044)
doRegisterCommentController (/Users/bpasero/.vscode-oss-dev/extensions/github.vscode-pull-request-github-0.89.2024053108/dist/extension.js:2069)
<anonymous> (/Users/bpasero/.vscode-oss-dev/extensions/github.vscode-pull-request-github-0.89.2024053108/dist/extension.js:2069)
_deliver (/Users/bpasero/Development/Microsoft/vscode-electron-22.x/src/vs/base/common/event.ts:1211)
fire (/Users/bpasero/Development/Microsoft/vscode-electron-22.x/src/vs/base/common/event.ts:1242)
set localFileChanges (/Users/bpasero/.vscode-oss-dev/extensions/github.vscode-pull-request-github-0.89.2024053108/dist/extension.js:2069)
initializePullRequestData (/Users/bpasero/.vscode-oss-dev/extensions/github.vscode-pull-request-github-0.89.2024053108/dist/extension.js:2069)
processTicksAndRejections (internal/process/task_queues:95)
await (Unknown Source:0)
processTicksAndRejections (internal/process/task_queues:95)
await (Unknown Source:0)
validateState (/Users/bpasero/.vscode-oss-dev/extensions/github.vscode-pull-request-github-0.89.2024053108/dist/extension.js:2069)
processTicksAndRejections (internal/process/task_queues:95)
await (Unknown Source:0)

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions