Skip to content

Don't reload entire DOM when getting data from GitHub #4371

@Thomas1664

Description

@Thomas1664

A few days before Christmas, this extension started to refresh the PR view and the active pull request panel more often. The problem is that the entire DOM will be recreated when the state changes. While the contents of the "add comment" textarea in the PR view survive the reload, unsaved changes to the PR title/ description do not survive this which is very annoying when editing it.

Steps to Reproduce:

  1. Open PR view
  2. Change PR title but don't submit your changes
  3. Wait a few minutes until PR view reloads (manually reload PR view doesn't reproduce the issue entirely)
  4. Notice in VS Code dev tools that the entire DOM disappears and is recreated and changes to e.g. the PR title are not preserved

Expected behaviour:

To not reload everything and therefore not loose any unsaved changes. When you pull refresh on the GitHub website, e.g. while writing this issue, no data is lost although the entire DOM gets recreated. However, GitHub is able to show new comments/ commits without reloading everything.

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions