Skip to content

A comment added on the right side of a diff editor may move to the left side on reload #153

@RMacfarlane

Description

@RMacfarlane
  1. Open a file change from the PR tree
  2. Add a new comment on the right hand side of the diff editor, on a line that isn't within an addition
  3. Close and reopen the file change. Comment now appears on the base file on the left

Since the comment isn't on an addition, showing it on the base file is the correct thing to do. However, it's confusing to have it move - I thought a comment had been lost for a second because it wasn't where I had added it.
comment_move

On GitHub, trying to add such a comment, the comment widget pops up on the left even though the click was on the right:
lhs_comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    githubRelated to GitHub APIux

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions