Skip to content

Limit gh pr commands to itself#1277

Merged
rebornix merged 2 commits intomasterfrom
rebornix/ghpr-commands-leaking
Jul 19, 2019
Merged

Limit gh pr commands to itself#1277
rebornix merged 2 commits intomasterfrom
rebornix/ghpr-commands-leaking

Conversation

@rebornix
Copy link
Member

@rebornix rebornix commented Jul 18, 2019

To avoid it bleed into comment widgets created by other extensions.

@rebornix rebornix requested a review from RMacfarlane July 18, 2019 21:46
Copy link
Contributor

@RMacfarlane RMacfarlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to do the same thing for the commands listed under comments/comment/title and comments/comment/context

@rebornix rebornix requested a review from RMacfarlane July 18, 2019 21:51
@rebornix
Copy link
Member Author

rebornix commented Jul 18, 2019

right, they are all leaked. updated now.,

@rebornix rebornix merged commit 4f8ee5a into master Jul 19, 2019
@rebornix rebornix deleted the rebornix/ghpr-commands-leaking branch July 19, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants