-
Notifications
You must be signed in to change notification settings - Fork 720
Description
Just had my first round of addressing code review comments in VSC. I took note of some areas of friction for me, and opportunities for us to improve the UX.
First off, I’m definitely liking the fact that there’s so much functionality that allows me to stay in the editor and in the context of my code! ✨ What we have is pretty sweet so far.
That said, I found myself choosing/having to go to dotcom for some things and doing some extra clicking/navigating around. Here’s when/why:
It’s not super smooth navigating from seeing a review comment in the overview page, to making changes in the code to address the comment. I have to click to the read-only editor that displays the inline comment, and then manually open the file:line-number to make the change. If there’s a more efficient way, it’s not super discoverable.
I noticed myself wanting to reply to a comment from the overview page, and feeling a bit annoyed that I had to click into the read-only editor to simply reply, and lose the context I was in while on the overview page.
This was exacerbated by the fact that when I go back to the overview page, the webview reloads and puts me back at the top. So I have to do lots of scrolling to go back to where I was while responding to review comments. I also find this irksome while testing changes during my normal development process.
Lastly, replying to a comment isn’t working for me. Might just be my setup (I’m currently on a branch, will test on master once I’m done addressing all of these code review comments). Curious to hear if others can repro this locally… #1200