Skip to content

Conversation

@tdscheper
Copy link
Contributor

Related: #356

@tdscheper
Copy link
Contributor Author

@microsoft-github-policy-service agree

@karthiknadig karthiknadig self-assigned this Apr 3, 2025
karthiknadig
karthiknadig previously approved these changes Apr 3, 2025
@karthiknadig karthiknadig added the bug Issue identified by VS Code Team member as probable bug label Apr 3, 2025
@karthiknadig karthiknadig enabled auto-merge (squash) April 3, 2025 18:23
@vs-code-engineering vs-code-engineering bot added this to the April 2025 milestone Apr 3, 2025
eleanorjboyd
eleanorjboyd previously approved these changes Apr 3, 2025
@eleanorjboyd
Copy link
Member

looks good there is just an issue with linting: https://github.com/microsoft/vscode-mypy/actions/runs/14002940023/job/39940477920?pr=357.

@tdscheper
Copy link
Contributor Author

@eleanorjboyd My changes have nothing to do with the linting error shown, but I can fix it by deleting the global var declaration on the offending line

global _reported_file_paths

auto-merge was automatically disabled April 4, 2025 03:18

Head branch was pushed to by a user without write access

@tdscheper tdscheper dismissed stale reviews from eleanorjboyd and karthiknadig via 14cfebf April 4, 2025 03:18
@karthiknadig karthiknadig enabled auto-merge (squash) April 4, 2025 22:32
auto-merge was automatically disabled April 17, 2025 02:03

Pull request was closed

@karthiknadig karthiknadig reopened this Apr 17, 2025
@karthiknadig karthiknadig enabled auto-merge (squash) April 17, 2025 02:04
@karthiknadig karthiknadig removed the request for review from eleanorjboyd April 17, 2025 02:04
@karthiknadig karthiknadig merged commit 8cb6bca into microsoft:main Apr 17, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue identified by VS Code Team member as probable bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants