support loading scoped modules at runtime#10
Merged
alexdima merged 2 commits intomicrosoft:masterfrom Mar 2, 2018
Merged
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds functionality to support loading a scoped node package in a non-build context (e.g. using the
yarn watchcommand, etc.).Two questions:
I don't know why the
/** @class */entries were added. I built the project usingnpm run watch-all. Do you know if that was the right command to use, or do I need to configure something else?Do you feel like this functionality needs testing. If so, could you point me in the direction of where/how to add it? I found the documentation regarding the testing structure to not be super helpful.