fix console line number in external browser#503
Merged
Conversation
TylerLeonhardt
approved these changes
Jun 5, 2023
|
Hello I am the Beginner Programming Learner, After the last update of the VSCODE I do have lots of issues and it requires update again and again. Which solution do you offer me to solve this problem ? |
|
This seems to be an issue still, I'm getting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#449
Fixes #508
What
createConsoleOverridedoes is just to callpostParentMessagebefore calling console output methods, but ifwindow.parent === windowpostParentMessagedoes nothing, so should we override console only ifwindow.parent !== window? At least this fixes the issue in external browser.