Skip to content

Pull Diagnostics does not remove old diagnostics if Language Server restarts #975

@d-biehl

Description

@d-biehl

I have tried to implement Pull Diagnostics for my language server. Sometimes it is necessary to restart the server instance, e.g. because of changed settings.
But when the server is restarted the old diagnostics are not deleted and are now double/triple/... present.

After analyzing the LS client, in my opinion, the "diagnostics" member in the DiagnosticRequestor must also be disposed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIssue identified by VS Code Team member as probable bug

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions