I have tried to implement Pull Diagnostics for my language server. Sometimes it is necessary to restart the server instance, e.g. because of changed settings.
But when the server is restarted the old diagnostics are not deleted and are now double/triple/... present.
After analyzing the LS client, in my opinion, the "diagnostics" member in the DiagnosticRequestor must also be disposed.