fix member expression completions#1758
Merged
Merged
Conversation
Contributor
Author
|
though there is still no completions for |
restore completions in computed
connor4312
reviewed
Jul 14, 2023
connor4312
reviewed
Jul 14, 2023
connor4312
left a comment
Member
There was a problem hiding this comment.
Took me a lil to grok but it looks okay. I think the main thing is just using estraverse's parent since the current implementation could incorrectly pass the parent as the previous sibling node.
Contributor
Author
But it is inside of the |
connor4312
approved these changes
Jul 14, 2023
hediet
approved these changes
Jul 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e.g.
arr.len|, seems it was broken for yearsfixes microsoft/vscode#168021