Add 'remoteHostHeader' option for node attach#1664
Merged
connor4312 merged 1 commit intomicrosoft:mainfrom Apr 18, 2023
Merged
Conversation
connor4312
approved these changes
Apr 18, 2023
mjbvz
approved these changes
Apr 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #778
Related: https://github.com/microsoft/vscode-js-debug/pull/667/files#r468093566
The use case is very clear here:
#778 (comment)
I notice that there is already a PR for this but with too old code base to merge.
I think the reason to take this feature is good enough since it is requested more than three times.
Clear use case again:
The remote gateway rule that reject host:localhost header is under control of my serverless cloud provider and I have no way to modify it. I already know that nodejs will only accept ip address or localhost, but I can change the Host header back to
localhostbehind the cloud gateway with one more websocket proxy that in my control.I think this is the only way to remote debug such strict server that not support customize firewall.