Adding support for indexed source maps.#1261
Merged
connor4312 merged 3 commits intomicrosoft:mainfrom May 17, 2022
Merged
Conversation
Indexed source maps, described in https://sourcemaps.info/spec.html#h.535es3xeprgt this should allow users to debug bundled output, like that produced by the closure-compiler when producing bundled output.
Member
|
Thanks for the PR! Can you add some test cases for these as well? |
Contributor
Author
|
Sure, let me add a unit tests |
Contributor
Author
|
Added new unit tests to check source map handling. |
Contributor
Author
|
Let me know if there are any additional tests I should add |
connor4312
approved these changes
May 17, 2022
Member
connor4312
left a comment
There was a problem hiding this comment.
I think this looks good. Thanks for the tests. The one missing thing is support for nested sections.[].urls, but I can add that in after this is merged.
alexdima
approved these changes
May 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indexed source maps, described in https://sourcemaps.info/spec.html#h.535es3xeprgt this should allow users to debug bundled output, like that produced by the closure-compiler when producing bundled output.
Fixes #1260