fix: prefer to parse source map directly before failling back to path mapping#1258
Merged
connor4312 merged 1 commit intomainfrom May 6, 2022
Merged
fix: prefer to parse source map directly before failling back to path mapping#1258connor4312 merged 1 commit intomainfrom
connor4312 merged 1 commit intomainfrom
Conversation
roblourens
approved these changes
May 6, 2022
Contributor
|
Just wanting to comment, that the reason for the original implementation was, that loading source maps from file has better performance than loading over network (which is mostly relevant for large source maps from remote locations only). To take advantage of this with the changes introduced in this PR, the source map just shouldn't be served, which is doable in most cases, I guess. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode#148864. See my comment on the bottom of an explaination of what changed.