Update userDataDir option documentation#1078
Merged
connor4312 merged 2 commits intomicrosoft:mainfrom Aug 24, 2021
Merged
Conversation
Contributor
Author
|
@connor4312 Please take a look when you have a moment, in case the language needs any change, I would be happy to update the PR accordingly. |
connor4312
reviewed
Aug 20, 2021
src/build/strings.ts
Outdated
| 'Whether scripts are loaded individually with unique sourcemaps containing the basename of the source file. This can be set to optimize sourcemap handling when dealing with lots of small scripts. If set to "auto", we\'ll detect known cases where this is appropriate.', | ||
| 'browser.userDataDir.description': | ||
| 'By default, the browser is launched with a separate user profile in a temp folder. Use this option to override it. Set to false to launch with your default user profile.', | ||
| 'By default, the browser is launched with a separate user profile in a temp folder. Use this option to override it. Set to false to launch with your default user profile. If `userDataDir` is specified, VS Code can not launch a new browser instance in the default profile if one is already running.', |
Member
There was a problem hiding this comment.
This phrasing is confusing, it'd be better to say "A new browser can't be launched if an instance is already running from the userDataDir."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding clarification to the
userDataDirsection to explain that another browser instance cannot be launched if this option has been specified, as is explained here.Closes #1072.