Allow void elements to be specified in data provider#125
Allow void elements to be specified in data provider#125aeschli merged 2 commits intomicrosoft:mainfrom
Conversation
…ased on HTML Data manager, Add void to webCustomData.ts
|
|
|
I suggest to make HTMLCompletion already gets a HTMLDataManager in the constructor. I'd turn folding and the parser also a class that gets the HTMLCompletion as context. |
… classes instead of exported functions
| } | ||
|
|
||
| public getSelectionRanges(document: TextDocument, positions: Position[]): SelectionRange[] { | ||
| const htmlDocument = this.htmlParser.parseDocument(document); |
There was a problem hiding this comment.
this is a slight tweak to parse the document here, it used to be parsed inside getApplicableRanges which would happen for each position, now it only parses the document once.
|
ok @aeschli I've created classes for those 3 functions. The formatting makes it look like there are more changes than there really is, but I had to indent all the functions since they are all inside classes now. |
|
Thanks a lot @hahn-kev, nice PR! |
|
You're welcome, happy to contribute |
This fixes #123
Please note, this PR drops support for checking void elements
keygenandmenuitemthese are long ago depreciated and not used it any tests. If you need these you can add them back in via a custom data provider and set"void": true.