Skip to content

Add doNotAddAttributeQuotes setting to disable automatic quotes#112

Merged
aeschli merged 3 commits into
microsoft:mainfrom
ssigwart:noQuotes
Sep 27, 2021
Merged

Add doNotAddAttributeQuotes setting to disable automatic quotes#112
aeschli merged 3 commits into
microsoft:mainfrom
ssigwart:noQuotes

Conversation

@ssigwart

Copy link
Copy Markdown
Contributor
  • For example, clas| completion will be class=| instead of class="|"

- For example, `clas|` completion will be `class=|` instead of `class="|"`
@aeschli aeschli merged commit 44727c3 into microsoft:main Sep 27, 2021
@aeschli

aeschli commented Sep 27, 2021

Copy link
Copy Markdown
Collaborator

I changed to use an enum.
Thanks @ssigwart for the PR!

@aeschli aeschli self-assigned this Sep 27, 2021
@aeschli aeschli added this to the September 2021 milestone Sep 27, 2021
@ssigwart

Copy link
Copy Markdown
Contributor Author

Great. Thank you, @aeschli! Do you want me to make updates to microsoft/vscode#129284 to match the new version and updated config name?

@aeschli

aeschli commented Sep 29, 2021

Copy link
Copy Markdown
Collaborator

@ssigwart I didn't find time to adopt microsoft/vscode#129284. If you want to, that would be great, otherwise I'll get to it next week.

@ssigwart ssigwart deleted the noQuotes branch September 30, 2021 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants