Skip to content
This repository was archived by the owner on Jul 15, 2023. It is now read-only.
This repository was archived by the owner on Jul 15, 2023. It is now read-only.

Modal popup on compile-time error. #1644

@jeffhoye

Description

@jeffhoye

Since this change, microsoft/vscode@b987d5b, to vscode in February, any trivial syntax error causes this modal popup when starting the debugger:

Failed to continue: Check the debug console for details.

image

The root cause of the error is usually a syntax error in my code, and the debug console properly explains the issue. However, the popup adds a very common and annoying step of having to close it before proceeding to fix the issue.

I'm not yet familiar with the details of how the language plugin should report these kind of issues to the debug subsystem, but it works differently in other language plugins. For example, the same kind of issue in Python, or Node.js doesn't result in a modal popup.

If there's no better way to report this issue to the vscode debug subsystem, my recommendation is to add a configuration option in the plugin to disable the error, or perhaps change them to warnings which show up in the new notification system rather than a modal popup.

I made such a patch in vscode "core" but they rejected it saying that maybe vscode-go should report the error differently.

Here's that discussion:
microsoft/vscode#48606

Here's some more info:
microsoft/vscode#45998
microsoft/vscode#44720

I'm happy to build a patch to this in vscode-go but want to make sure there's not a better or existing workaround already.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions