Skip to content

Add pnpm as a package manager #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aeschli merged 10 commits into from
Jul 6, 2022
Merged

Add pnpm as a package manager #339

aeschli merged 10 commits into from
Jul 6, 2022

Conversation

@nhedger
Copy link
Contributor

@nhedger nhedger commented Apr 14, 2022 •
edited
Loading

Description

This PR adds support for pnpm as a package manager.

Closes #324

Changes

Based on the existing tests, I've created additional tests to validate support for pnpm with all relevant templates.

While implementing the sample notebook renderer with pnpm test, I had to update the ext-notebook-renderer template because the package manager was hardcoded to npm. It will now be replaced by the selected package manager, as in other templates.

Modifying the ext-notebook-renderer template initially broke the sample notebook renderer test because the prompt defined yarn while it expected to find npm. I fixed that by replacing the prompt with npm.

Checklist

  • Tests cover pnpm usage
  • CLI help has been updated to include pnpm
  • CLI prompt has been updated to include pnpm
  • Readme has been updated to include pnpm

@ghost
Copy link

ghost commented Apr 14, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@nhedger nhedger marked this pull request as ready for review April 14, 2022 22:36
@nhedger nhedger marked this pull request as draft April 14, 2022 23:45
@nhedger nhedger marked this pull request as ready for review April 14, 2022 23:53
@nhedger
Copy link
Contributor Author

nhedger commented Jun 11, 2022

Hey @aeschli,

Friendly ping about this PR.

Is anything else needed from me to move forward with it?

@aeschli aeschli self-assigned this Jul 6, 2022
@aeschli aeschli self-requested a review July 6, 2022 13:15
@aeschli aeschli added this to the July 2022 milestone Jul 6, 2022
@aeschli aeschli requested a review from dbaeumer July 6, 2022 13:17
@aeschli aeschli merged commit 3b223ed into microsoft:main Jul 6, 2022
@aeschli
Copy link
Collaborator

aeschli commented Jul 6, 2022

Thanks @nhedger !

@nhedger nhedger deleted the feat/add-pnpm-support branch July 6, 2022 16:24
@awxiaoxian2020
Copy link

awxiaoxian2020 commented Jan 7, 2025

I think we should revert this. Because vsce doesn't support pnpm. See microsoft/vscode-vsce#421 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbaeumer dbaeumer dbaeumer approved these changes

@aeschli aeschli aeschli approved these changes

Assignees

@aeschli aeschli

Labels

None yet

Projects

None yet

Milestone

July 2022

Development

Successfully merging this pull request may close these issues.

Add pnpm as a package manager

4 participants

@nhedger @aeschli @awxiaoxian2020 @dbaeumer