Skip to content

Change the flake8 version string in readme.md to be pip compatible #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
karthiknadig merged 2 commits into from
Nov 29, 2023
Merged

Change the flake8 version string in readme.md to be pip compatible #257

karthiknadig merged 2 commits into from
Nov 29, 2023

Conversation

@safiyat
Copy link
Contributor

@safiyat safiyat commented Nov 20, 2023

Changed the flake8 version string to be pip compatible.

@safiyat
Updated the README.md.
612f12a 
Changed the flake8 version string to be pip compatible.

Signed-off-by: Md Safiyat Reza <safiyat@voereir.com>
@karthiknadig
Copy link
Member

karthiknadig commented Nov 20, 2023

@safiyat This can break nox session to validate readme. Can you update that as well?

@karthiknadig karthiknadig self-assigned this Nov 20, 2023
@karthiknadig karthiknadig self-requested a review November 20, 2023 19:22
@safiyat
Updated the noxfile and gitignore.
2b91178 
Updated the noxfile to accomodate for change in the README of the requirement string.

Updated the gitignore file to ignore .DS_Store files.

Signed-off-by: Md Safiyat Reza <safiyat@voereir.com>
@safiyat
Copy link
Contributor Author

safiyat commented Nov 21, 2023

@safiyat This can break nox session to validate readme. Can you update that as well?

Done. Sorry I missed those changes to be made, earlier.

@safiyat
Copy link
Contributor Author

safiyat commented Nov 21, 2023

@safiyat please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="VoerEir AB"

@safiyat
Copy link
Contributor Author

safiyat commented Nov 28, 2023

@karthiknadig could you please check now?

@karthiknadig karthiknadig changed the title Updated the README.md. Change the flake8 version string in readme.md to be pip compatible Nov 29, 2023
@karthiknadig karthiknadig enabled auto-merge (squash) November 29, 2023 02:43
@karthiknadig karthiknadig merged commit efeb1ea into microsoft:main Nov 29, 2023
@safiyat safiyat deleted the update_readme_flake8_version_string branch November 29, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

@anthonykim1 anthonykim1 anthonykim1 approved these changes

Assignees

@karthiknadig karthiknadig

Labels

debt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@safiyat @karthiknadig @anthonykim1