This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Place VS Code inside insiders/stable sub-folders of .vs-test#97
Merged
bpasero merged 1 commit intomicrosoft:masterfrom Mar 8, 2018
Merged
Place VS Code inside insiders/stable sub-folders of .vs-test#97bpasero merged 1 commit intomicrosoft:masterfrom
bpasero merged 1 commit intomicrosoft:masterfrom
Conversation
This avoids files overwriting each other from each version on Windows which might cause issues if you run tests for stable, then insiders, then stable again.
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids files overwriting each other from each version on Windows which might cause issues if you run tests for stable, then insiders, then stable again.
Slightly related to #94.
I've tested on Windows and Mac OS but don't have easy access to a Linux machine (the change is fairly trivial, however).
This could break people if they're relying on the executable being in a specific location in other scripts, but this seems very unlikely (and the fix is fairly obvious if it does break you).