This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Honor npm config proxy settings#67
Merged
bpasero merged 2 commits intomicrosoft:masterfrom Jun 27, 2017
bvandre:master
Merged
Conversation
Member
|
@bvandre thanks, good start. Would it make sense to also support Also, there is another place where a request is being made: https://github.com/Microsoft/vscode-extension-vscode/blob/master/bin/test#L88 |
Contributor
Author
|
I updated to add a check to see if the protocol was https and to use the correct proxy value. I am not sure if we want to add a fallback to use |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request to solve issue #65