eslintignore comment syntax highlighting#473
eslintignore comment syntax highlighting#473dbaeumer merged 2 commits intomicrosoft:masterfrom Hirse:master
Conversation
|
@aeschli can you please have a quick review. You know a lot more about this than I do. |
|
The change looks good! @Hirse If you wanted you could make a similar addition for |
|
@aeschli Do you mean in vscode? |
|
@Hirse A generic ignore-file language makes sense. We could still place it along with the git extension |
|
That makes sense to me as well. That would mean for eslint we would then simply reference the genernal syntax. |
|
@aeschli do you mean adding a definition in vscode |
|
@Hirse I'd suggest to add it to vscode/extensions/git |
|
@aeschli do you recommend that we wait with this in ESLint and then reuse the one that goes into git? |
|
@dbaeumer Sorry for the delay, I have changed the code to reference the existing |
|
Thanks!. |
Colors comments and enables commenting of lines using keyboard shortcut.
see #459