Skip to content

eslintignore comment syntax highlighting#473

Merged
dbaeumer merged 2 commits intomicrosoft:masterfrom
Hirse:master
Aug 20, 2018
Merged

eslintignore comment syntax highlighting#473
dbaeumer merged 2 commits intomicrosoft:masterfrom
Hirse:master

Conversation

@Hirse
Copy link
Contributor

@Hirse Hirse commented May 24, 2018

Colors comments and enables commenting of lines using keyboard shortcut.

see #459

@dbaeumer
Copy link
Member

@aeschli can you please have a quick review. You know a lot more about this than I do.

@dbaeumer dbaeumer requested a review from aeschli May 25, 2018 08:35
@aeschli
Copy link

aeschli commented May 25, 2018

The change looks good!

@Hirse If you wanted you could make a similar addition for gitignore files as we don't have any colorization there as well.
We could share the grammar of the two, if we're sure that the syntaxes are identical.

@Hirse
Copy link
Contributor Author

Hirse commented May 25, 2018

@aeschli Do you mean in vscode?
If we add that, would it make sense to define some kind of generic ignore-file language for gitignore, eslintignore, npmignore, and possibly others?

@aeschli
Copy link

aeschli commented May 28, 2018

@Hirse A generic ignore-file language makes sense. We could still place it along with the git extension

@dbaeumer
Copy link
Member

That makes sense to me as well. That would mean for eslint we would then simply reference the genernal syntax.

@Hirse
Copy link
Contributor Author

Hirse commented May 29, 2018

@aeschli do you mean adding a definition in vscode extensions/git/languages or adding a new ignore extension which only contains this language definition?

@aeschli
Copy link

aeschli commented May 29, 2018

@Hirse I'd suggest to add it to vscode/extensions/git

@dbaeumer
Copy link
Member

@aeschli do you recommend that we wait with this in ESLint and then reuse the one that goes into git?

@Hirse
Copy link
Contributor Author

Hirse commented Aug 14, 2018

@dbaeumer Sorry for the delay, I have changed the code to reference the existing ignore language as @aeschli did in microsoft/vscode@eb2b51a so this should be good to go now.

@dbaeumer
Copy link
Member

Thanks!.

@dbaeumer dbaeumer merged commit 25b03e8 into microsoft:master Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants