Skip to content

Check for -- when disabling rules#1506

Merged
dbaeumer merged 4 commits intomicrosoft:mainfrom
MariaSolOs:fix-disable-comment
Aug 8, 2022
Merged

Check for -- when disabling rules#1506
dbaeumer merged 4 commits intomicrosoft:mainfrom
MariaSolOs:fix-disable-comment

Conversation

@MariaSolOs
Copy link
Contributor

Fixes the problem described in #1505.

Copy link
Member

@dbaeumer dbaeumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, the PR looks great. Thanks for providing it.

@dbaeumer dbaeumer requested a review from sandy081 August 8, 2022 09:43
Copy link
Member

@sandy081 sandy081 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbaeumer dbaeumer merged commit 1fa8e21 into microsoft:main Aug 8, 2022
@MariaSolOs MariaSolOs deleted the fix-disable-comment branch August 9, 2022 02:18
@dbaeumer dbaeumer added this to the 2.2.next milestone Aug 12, 2022
@dbaeumer dbaeumer modified the milestones: 2.2.next, 2.4.0 Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants