Allow user to ignore server errors.#1375
Conversation
|
Hi @dbaeumer while working on this PR I noticed that the status bar color is not changing on error or warning status, it's on purpose? Maybe with the option to silent server errors we should highlight the status bar to show to the user that something is wrong and the file is not being parsed, what do you think? Another option that I thought about adding with this (or another) PR is some commands to allow the user to silent or display all server errors for the session. Could this be a good option when the error message changes on repeated errors? Maybe this could be helpful to alleviate other issues like #1238 |
|
@edupsousa sorry for the delay :-) We should definitely update the color. It did in the past, but the code got somehow lost :-). It is here: vscode-eslint/client/src/extension.ts Line 834 in 7568b4c The I would actually not add any additional commands. The reasons are:
|
e75c347 to
75f01e4
Compare
No problem with the delay. The year is ending but the work just increases. :-) I was playing around another day and already did the background color update, but the branch where I did it is polluted with other things that I was playing. I will do some cleanup and tests before submitting it in a new PR. |
|
@edupsousa I looked at the code again and did you do any chances to update the background color? It is not in the PR. |
146c0f1 to
88ec29f
Compare
fc79f6c to
65a4162
Compare
@dbaeumer, I was planning to put it on a separate PR, sorry for the confusion. But, to keep it simple I just added the status bar color code to this same PR. |
|
@edupsousa thanks. Will have a look |
This PR resolves #1206 by allowing users to ignore server errors by error message until the server is restarted.
The error dialog is not displayed, but the error is still shown on the output channel.