Skip to content

Allow user to ignore server errors.#1375

Merged
dbaeumer merged 3 commits intomicrosoft:mainfrom
edupsousa:feature/ignore-server-errors
Jan 14, 2022
Merged

Allow user to ignore server errors.#1375
dbaeumer merged 3 commits intomicrosoft:mainfrom
edupsousa:feature/ignore-server-errors

Conversation

@edupsousa
Copy link
Contributor

@edupsousa edupsousa commented Nov 21, 2021

This PR resolves #1206 by allowing users to ignore server errors by error message until the server is restarted.

The error dialog is not displayed, but the error is still shown on the output channel.

@edupsousa
Copy link
Contributor Author

Hi @dbaeumer while working on this PR I noticed that the status bar color is not changing on error or warning status, it's on purpose? Maybe with the option to silent server errors we should highlight the status bar to show to the user that something is wrong and the file is not being parsed, what do you think?

Another option that I thought about adding with this (or another) PR is some commands to allow the user to silent or display all server errors for the session. Could this be a good option when the error message changes on repeated errors?

Maybe this could be helpful to alleviate other issues like #1238

@dbaeumer
Copy link
Member

@edupsousa sorry for the delay :-)

We should definitely update the color. It did in the past, but the code got somehow lost :-). It is here:

let backgroundColor: ThemeColor | undefined;

The background is never updated.

I would actually not add any additional commands. The reasons are:

  • I think not showing the same message over and over is a good default
  • clicking on the ESLint status takes you to the output channel.

@edupsousa edupsousa force-pushed the feature/ignore-server-errors branch from e75c347 to 75f01e4 Compare December 14, 2021 14:05
@edupsousa edupsousa requested a review from dbaeumer December 14, 2021 14:28
@edupsousa
Copy link
Contributor Author

@edupsousa sorry for the delay :-)

We should definitely update the color. It did in the past, but the code got somehow lost :-). It is here:

let backgroundColor: ThemeColor | undefined;

The background is never updated.

I would actually not add any additional commands. The reasons are:

  • I think not showing the same message over and over is a good default
  • clicking on the ESLint status takes you to the output channel.

No problem with the delay. The year is ending but the work just increases. :-)

I was playing around another day and already did the background color update, but the branch where I did it is polluted with other things that I was playing. I will do some cleanup and tests before submitting it in a new PR.

@dbaeumer
Copy link
Member

dbaeumer commented Jan 6, 2022

@edupsousa I looked at the code again and did you do any chances to update the background color? It is not in the PR.

@edupsousa edupsousa force-pushed the feature/ignore-server-errors branch from 146c0f1 to 88ec29f Compare January 11, 2022 17:26
@edupsousa edupsousa force-pushed the feature/ignore-server-errors branch from fc79f6c to 65a4162 Compare January 11, 2022 17:36
@edupsousa
Copy link
Contributor Author

@edupsousa I looked at the code again and did you do any chances to update the background color? It is not in the PR.

@dbaeumer, I was planning to put it on a separate PR, sorry for the confusion. But, to keep it simple I just added the status bar color code to this same PR.

@dbaeumer
Copy link
Member

@edupsousa thanks. Will have a look

@dbaeumer dbaeumer merged commit 01c81e9 into microsoft:main Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When rulePath is missing, error notification appears on every file edit

2 participants