Skip to content

location is restricted in a limited area for debug toolbar as floating#7704

Merged
ntrogh merged 2 commits intomicrosoft:mainfrom
Cecil0o0:Cecil0o0-patch-1
Oct 24, 2024
Merged

location is restricted in a limited area for debug toolbar as floating#7704
ntrogh merged 2 commits intomicrosoft:mainfrom
Cecil0o0:Cecil0o0-patch-1

Conversation

@Cecil0o0
Copy link
Copy Markdown
Contributor

image

the location of debug toolbar has a limit top value of property of CSS, actually. As shown below:

20241023-221353

Perhaps it could be more fit for us to describe more for currently technically implement.

In addition, editor may not be appropriate because debug toolbar would appear outside the editor, therefore window could be right~

Copy link
Copy Markdown
Contributor

@ntrogh ntrogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. Added a suggestion for one of the changes.

Co-authored-by: Nick Trogh <1908215+ntrogh@users.noreply.github.com>
@Cecil0o0
Copy link
Copy Markdown
Contributor Author

@ntrogh Thanks for the suggestion.

Copy link
Copy Markdown
Contributor

@ntrogh ntrogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cecil0o0 Thanks for clarifying this in our docs!

@ntrogh ntrogh merged commit e7d4bf3 into microsoft:main Oct 24, 2024
@vs-code-engineering vs-code-engineering bot added this to the October 2024 milestone Oct 24, 2024
@Cecil0o0 Cecil0o0 deleted the Cecil0o0-patch-1 branch October 24, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants