Skip to content

fix: add missing pricing parameter to manifest#6587

Merged
gregvanl merged 1 commit intomicrosoft:mainfrom
bandantonio:missing-pricing-param-in-manifest
Aug 11, 2023
Merged

fix: add missing pricing parameter to manifest#6587
gregvanl merged 1 commit intomicrosoft:mainfrom
bandantonio:missing-pricing-param-in-manifest

Conversation

@bandantonio
Copy link
Contributor

No description provided.

@gregvanl gregvanl added the extensibility extension author content under /api label Aug 11, 2023
Copy link

@gregvanl gregvanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gregvanl gregvanl enabled auto-merge (squash) August 11, 2023 17:17
@gregvanl gregvanl merged commit b33cd76 into microsoft:main Aug 11, 2023
@gregvanl
Copy link

Hi @bandantonio While reviewing this PR, I noticed that the pricing attribute is not included in the package.json schema and so does not show up in IntelliSense.
Would you like to submit a PR to the vscode product repo to add this attribute to the schema?
You would update IJSONSchema in https://github.com/microsoft/vscode/blob/main/src/vs/workbench/services/extensions/common/extensionsRegistry.ts

@bandantonio
Copy link
Contributor Author

@gregvanl Yes, I definitely would like to. Should I create an issue for that?

@gregvanl
Copy link

@bandantonio That is a good idea for tracking and context and then link the PR to the issue.

You could call out the missing attribute and add an image like:

image

@bandantonio bandantonio deleted the missing-pricing-param-in-manifest branch August 11, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extensibility extension author content under /api

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants