Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree company="Hilma" |
aeschli
approved these changes
Feb 23, 2026
Collaborator
|
Thanks @ej-shafran ! |
joaomoreno
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec
Sources in the spec:
Notes
This is my first time opening a PR here, but I was trying to solve SCSS deprecation issues in one of my projects and ran into this issue, so I was motivated to fix this. I hope I got the gist of how to properly parse things, but if I returned
nullwhere I was supposed tomarkError, or if I checkedisErroneousinstead of returningnull, etc. - I'd be glad to fix any mistakes.Relevant Issues
Closes #466.
The spec mentions that
@containercan also be defined usingboolean-expression, so I can rewrite the parsing for container queries to reuse_parseBooleanExpression- and that will let me easily solve #454 as well.