Support @starting-style
#421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeschli
requested changes
Jan 27, 2025
Contributor
Author
|
@aeschli The review comments were addressed. |
lilnasy
commented
Mar 11, 2025
Collaborator
|
Thanks @lilnasy, looks good! |
aeschli
approved these changes
Mar 13, 2025
rebornix
approved these changes
Mar 13, 2025
|
Curious, this says merged and closed, but I am still getting this error: Am I missing something? Thanks! |
Collaborator
|
@aarontgrogg The latest VS Code release is 1.108 |
Crud, Update Mode was set to "Never" for some reason... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@starting-style#403._parseContainerDeclaration(),._parseMediaDeclaration(),._parseSupportsDeclaration(), and._parseLayerDeclaration()all contain the exact same logic. It seems community contributions over the years kept copying it.._parseStartingStyleDeclaration(). Might be something to revisit.