feat: support hover tooltip for scss#367
Merged
aeschli merged 5 commits intomicrosoft:mainfrom Feb 28, 2024
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
Author
|
@aeschli ? |
aeschli
requested changes
Feb 21, 2024
src/services/cssHover.ts
Outdated
| const matches = node.getText().match(regex); | ||
| flagOpts = { | ||
| isMedia:true, | ||
| text:matches?.[0].toString()! |
Collaborator
There was a problem hiding this comment.
toString()! is not necessary
Contributor
Author
There was a problem hiding this comment.
ok, I removed it.
aeschli
requested changes
Feb 21, 2024
src/services/cssHover.ts
Outdated
| for (let i = 0; i < nodepath.length; i++) { | ||
| const node = nodepath[i]; | ||
|
|
||
| if (node instanceof nodes.Media){ |
Collaborator
There was a problem hiding this comment.
Please run the formatter (default Typescript formatter)
Contributor
Author
There was a problem hiding this comment.
Is this ok now, I runned default prettier.
Contributor
Author
There was a problem hiding this comment.
Should I rise an issue for format script. It might helps other engineers to follow common format configuration.
a1a5c2e to
dfb8281
Compare
Contributor
Author
|
@aeschli have any prettier config? {
"semi": true,
"singleQuote": true,
"useTabs": true,
"trailingComma": "all",
"arrowParens": "always",
"bracketSpacing": true,
"printWidth": 200
} |
Collaborator
|
No prettier, just the built-in TypeScript compiler with default settings. |
dfb8281 to
a6f7ec9
Compare
Contributor
Author
|
@aeschli any update? |
aeschli
approved these changes
Feb 28, 2024
chrmarti
approved these changes
Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: microsoft/vscode#194707 #271