✋ Ignore missing standard properties in contexts with vendor-specific pseudo-elements#303
Merged
aeschli merged 5 commits intomicrosoft:mainfrom Nov 9, 2022
Conversation
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
… pseudo-elements Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
aeschli
previously approved these changes
Nov 2, 2022
dbaeumer
approved these changes
Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode#164350
@aeschli Sorry that I'm not deeply familiar with CSS language/syntax and its features.
What's done in this PR is that when vendor-specific pseudo-element selectors (e.g.,
::-webkit-slider-thumb) are encountered, we'd then avoid emitting linter errors/warnings about missing standard properties.Take the cases below as examples (also included as test cases). Previously, the linter would ask to also include the standard
appearanceproperty. Now, the first two cases are fine.