Skip to content

Ability to use suggest participants for SCSS/Less mixins#201

Merged
aeschli merged 1 commit intomicrosoft:masterfrom
mrmlnc:more_completion_hooks
Feb 17, 2020
Merged

Ability to use suggest participants for SCSS/Less mixins#201
aeschli merged 1 commit intomicrosoft:masterfrom
mrmlnc:more_completion_hooks

Conversation

@mrmlnc
Copy link
Copy Markdown
Contributor

@mrmlnc mrmlnc commented Dec 11, 2019

As a part of the revival of the vscode-scss plugin I want to use the completion participant mechanism how it is done in the built-in VSCode CSS extension (click).

I found that for successful application of this mechanism I only lack references to mixins. So, just add it :)

My motivation:

  • Use the same mechanism as the built-in solution to avoid the difference in experience.

@mrmlnc mrmlnc force-pushed the more_completion_hooks branch 2 times, most recently from 58ce57e to 66eb0f3 Compare December 11, 2019 08:57
@mrmlnc mrmlnc force-pushed the more_completion_hooks branch from 66eb0f3 to 1d48074 Compare December 27, 2019 17:28
@aeschli aeschli merged commit 338a406 into microsoft:master Feb 17, 2020
@aeschli aeschli added this to the February 2020 milestone Feb 17, 2020
@aeschli
Copy link
Copy Markdown
Collaborator

aeschli commented Feb 17, 2020

Thanks @mrmlnc ! (And sorry for only seeing this PR right now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants