Yemohyle/edit feedback msft internal#984
Merged
roblourens merged 4 commits intomicrosoft:mainfrom Sep 9, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds edit keep/undo tracking events to Microsoft internal telemetry to improve data joining capabilities. The change duplicates the existing 'panel.edit.feedback' telemetry event to send the same data to both the standard telemetry service and the internal MSFT telemetry service.
Key Changes
- Added duplicate telemetry event sending for 'panel.edit.feedback' to MSFT internal telemetry service
- Maintains identical event structure and data for both telemetry destinations
Comments suppressed due to low confidence (1)
src/extension/conversation/vscode-node/userActions.ts:1
- The telemetry event data is duplicated across both calls. Consider extracting the properties and measurements into variables to reduce code duplication and improve maintainability.
/*---------------------------------------------------------------------------------------------
roblourens
approved these changes
Sep 9, 2025
Tyriar
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add edit keep/undo tracking evnents ('panel.edit.feedback') to MSFT internal telemetry as well. It is a valuable quality signal. Currently it goes to another cluster which make it hard to join with events in MSFT Internal telemetry.