Fixes to adaptive aggressiveness updates#3441
Merged
ulugbekna merged 11 commits intomicrosoft:mainfrom Feb 4, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens validation and telemetry around the adaptive aggressiveness “user happiness” configuration and adds tests to validate the scoring and configuration parsing behavior.
Changes:
- Extends
USER_HAPPINESS_SCORE_CONFIGURATION_VALIDATORto enforce stricter constraints on ignored vs rejected scores. - Refactors user interaction data to use a dedicated
NESUserActiontype, wires inITelemetryServiceto log parse/validation failures of the happiness configuration, and updates the corresponding tests. - Adds richer unit tests for the user happiness scoring algorithm and configuration parsing, including v1/v2 behavior comparisons and configuration-string round-tripping.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/platform/inlineEdits/common/dataTypes/xtabPromptOptions.ts |
Adds tighter validation for happiness score configuration values, including a new constraint on ignoredScore relative to rejectedScore and parsing of the configuration string via a validator. |
src/extension/inlineEdits/common/userInteractionMonitor.ts |
Introduces the NESUserAction type, updates scoring helpers to use it, and adds telemetry/logging around failures to parse/validate the experimental happiness score configuration. |
src/extension/inlineEdits/test/common/userInteractionMonitor.spec.ts |
Updates the test monitor to pass a telemetry service and adjusts comments/instantiations to align with the new constructor signature and default configuration behavior. |
src/extension/inlineEdits/test/common/userHappinessScore.spec.ts |
Refactors tests to use NESUserAction/action() helper, exercises ignored-action handling and weighting behavior more explicitly, and adds new tests for configuration-string parsing and usage. |
ulugbekna
approved these changes
Feb 4, 2026
alexr00
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.