This repository was archived by the owner on Oct 2, 2021. It is now read-only.
Now we send more telemetry information for some errors#319
Merged
roblourens merged 3 commits intomicrosoft:masterfrom Apr 2, 2018
Merged
Now we send more telemetry information for some errors#319roblourens merged 3 commits intomicrosoft:masterfrom
roblourens merged 3 commits intomicrosoft:masterfrom
Conversation
roblourens
suggested changes
Mar 29, 2018
| private _message: DebugProtocol.Message; | ||
|
|
||
| constructor (message: DebugProtocol.Message) { | ||
| super(message.format); |
Member
There was a problem hiding this comment.
The error message won't include values inserted with {0}, we should include those, even if we just concatenate them to the end.
src/errors.ts
Outdated
| this._message = message; | ||
| } | ||
|
|
||
| public get id(): number { |
Member
There was a problem hiding this comment.
I think this object needs to be JSON.stringified as a DebugProtocol.Message. I think this will include the message under _message but won't be in the shape of a message?
Maybe just copy all the values off the message onto this?
roblourens
approved these changes
Apr 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want all rejections and throws to be errors so we can get a call stack for telemetry