Skip to content
This repository was archived by the owner on Oct 2, 2021. It is now read-only.

Now the start-up timings events can include a failure reason#316

Merged
roblourens merged 1 commit intomicrosoft:masterfrom
digeff:add_startup_failure_reason
Mar 23, 2018
Merged

Now the start-up timings events can include a failure reason#316
roblourens merged 1 commit intomicrosoft:masterfrom
digeff:add_startup_failure_reason

Conversation

@digeff
Copy link
Contributor

@digeff digeff commented Mar 23, 2018

When we detect that the user requests for an unreachable url, we'll put that in the reason.

This change will break the debug adapters until we update them to use the new parameter required for the new signature.
This is related to this chrome-debug PR: microsoft/vscode-chrome-debug#630

@roblourens
Copy link
Member

This change will break the debug adapters until we update them to use the new parameter required for the new signature.

Good excuse to bump to 4.0.0 :)

@roblourens roblourens merged commit 6601e3b into microsoft:master Mar 23, 2018
@digeff digeff deleted the add_startup_failure_reason branch March 23, 2018 22:52
@roblourens roblourens added this to the March 2018 milestone Apr 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants